Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preview-mode docs/examples typo #11345

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Fix preview-mode docs/examples typo #11345

merged 1 commit into from
Mar 25, 2020

Conversation

queq1890
Copy link
Contributor

@queq1890 queq1890 commented Mar 25, 2020

Changing This secret should only be know to This secret should only be known.

be know => be known
@queq1890 queq1890 changed the title Fix preview-mode typo Fix preview-mode docs/examples typo Mar 25, 2020
@ijjk
Copy link
Member

ijjk commented Mar 25, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary queq1890/next.js fix-preview-mode-typo Change
buildDuration 11.2s 11.2s ⚠️ +16ms
nodeModulesSize 53 MB 53 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary queq1890/next.js fix-preview-mode-typo Change
main-HASH.js gzip 6.24 kB 6.24 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.2 kB 56.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary queq1890/next.js fix-preview-mode-typo Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary queq1890/next.js fix-preview-mode-typo Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary queq1890/next.js fix-preview-mode-typo Change
_app.js gzip 1.24 kB 1.24 kB
_error.js gzip 3.15 kB 3.15 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 2.03 kB 2.03 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.86 kB 7.86 kB
Client Pages Modern
zeit/next.js canary queq1890/next.js fix-preview-mode-typo Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary queq1890/next.js fix-preview-mode-typo Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary queq1890/next.js fix-preview-mode-typo Change
index.html gzip 918 B 918 B
link.html gzip 927 B 927 B
withRouter.html gzip 916 B 916 B
Overall change 2.76 kB 2.76 kB

Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary queq1890/next.js fix-preview-mode-typo Change
buildDuration 11.9s 12.2s ⚠️ +287ms
nodeModulesSize 53 MB 53 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary queq1890/next.js fix-preview-mode-typo Change
main-HASH.js gzip 6.24 kB 6.24 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.2 kB 56.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary queq1890/next.js fix-preview-mode-typo Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary queq1890/next.js fix-preview-mode-typo Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary queq1890/next.js fix-preview-mode-typo Change
_app.js gzip 1.24 kB 1.24 kB
_error.js gzip 3.15 kB 3.15 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 2.03 kB 2.03 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.86 kB 7.86 kB
Client Pages Modern
zeit/next.js canary queq1890/next.js fix-preview-mode-typo Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary queq1890/next.js fix-preview-mode-typo Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary queq1890/next.js fix-preview-mode-typo Change
_error.js gzip 294 kB 293 kB -107 B
404.html gzip 1.32 kB 1.32 kB
hooks.html gzip 959 B 959 B
index.js gzip 293 kB 294 kB ⚠️ +410 B
link.js gzip 302 kB 301 kB -122 B
routerDirect.js gzip 300 kB 300 kB ⚠️ +116 B
withRouter.js gzip 300 kB 300 kB ⚠️ +98 B
Overall change 1.49 MB 1.49 MB ⚠️ +395 B

@timneutkens timneutkens merged commit 67fd72b into vercel:canary Mar 25, 2020
@timneutkens
Copy link
Member

Thanks!

@queq1890 queq1890 deleted the fix-preview-mode-typo branch March 25, 2020 17:51
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants