Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next v9 typescript dev experience - thoughts #7848

Closed
jeremy-coleman opened this issue Jul 9, 2019 · 6 comments
Closed

next v9 typescript dev experience - thoughts #7848

jeremy-coleman opened this issue Jul 9, 2019 · 6 comments

Comments

@jeremy-coleman
Copy link

jeremy-coleman commented Jul 9, 2019

a few observations.

  1. lint "failures" shouldn't stop the app from compiling. it does now , similar to CRA.
  2. fixing lint failures often requires restarting the server because the watchers wont trigger.
  3. add a check for a tsconfig at process.cwd() , and extending it if it exists. For example, if i run 'next src' in a project with src/pages/.. , the current behavior won't use the root tsconfig.
  4. the tsconfig paths webpack plugin works with babel (because it modifies the webpack resolution), so you should just use it by default imo(it won't do anything if the user hasn't set up a baseUrl or path alias anyway)
  5. The linter runs on all files, basically negating the HUGE benefit of next's lazy compilation.
    IMO, just remove the linter completely and let users run it independently

update:
create a new issue here #7908
corresponding repo
update: https://github.com/jeremy-coleman/next-tsc-proposal/tree/gulp

going to close this, to focus on a solution

@kachkaev
Copy link
Contributor

kachkaev commented Jul 9, 2019

Similar thoughts in #7687. I wish we could simply disable TypeScript linting during dev and build without having to apply a hacky workaround.

@timneutkens
Copy link
Member

This doesn't follow the issue template 😢

@elken
Copy link

elken commented Jul 10, 2019

Agreed. I, as I'm sure most people do, already have linting on my editor and it would be nice to either disable completely or removing the strictness.

@Janpot
Copy link
Contributor

Janpot commented Jul 10, 2019

It kind of breaks the development flow for me . While I'm working on something, I don't need 100% strict type checking all the time, often I don't care about implicit any types and things like that until I've fully understood the problem and solution of the particular thing I'm working on. Imagine a linter preventing you from running your code because you didn't put a semicolon.

@Timer
Copy link
Member

Timer commented Aug 11, 2019

Closing in favor of #8331, someone can feel free to implement this feature!

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants