Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for fixed-base constants #417

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

daira
Copy link
Contributor

@daira daira commented Feb 6, 2024

  • Add a pointer to how the Z and U constants for fixed-base scalar multiplication can be reproduced.
  • Correct errors and omissions in the documentation of the fixed-base generators.

@daira daira added the documentation Improvements or additions to documentation label Feb 6, 2024
@daira daira assigned ebfull and str4d Feb 6, 2024
@daira daira force-pushed the improve-doc-for-fixed-base-constants branch from fbcbccf to 160a846 Compare February 6, 2024 12:49
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a2abbb) 80.64% compared to head (fbcbccf) 80.64%.

❗ Current head fbcbccf differs from pull request most recent head 160a846. Consider uploading reports for the commit 160a846 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #417   +/-   ##
=======================================
  Coverage   80.64%   80.64%           
=======================================
  Files          30       30           
  Lines        3152     3152           
=======================================
  Hits         2542     2542           
  Misses        610      610           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

  multiplication can be reproduced.
* Correct errors and omissions in the documentation of the fixed-base
  generators.

Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
@daira daira force-pushed the improve-doc-for-fixed-base-constants branch from 160a846 to ae1ba27 Compare February 6, 2024 21:20
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ae1ba27. Doc-only.

@daira daira merged commit 3d79ba4 into zcash:main Feb 6, 2024
13 checks passed
@daira daira deleted the improve-doc-for-fixed-base-constants branch February 6, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants