Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Modernise workflows #402

Merged
merged 2 commits into from
Nov 30, 2023
Merged

CI: Modernise workflows #402

merged 2 commits into from
Nov 30, 2023

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Nov 28, 2023

We now check in Cargo.lock for testing against MSRV.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c48247d) 83.25% compared to head (a12661c) 81.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
- Coverage   83.25%   81.07%   -2.19%     
==========================================
  Files          32       31       -1     
  Lines        2658     3112     +454     
==========================================
+ Hits         2213     2523     +310     
- Misses        445      589     +144     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This is currently "whatever lockfile happened to last work for str4d",
but going forward will be the lockfile we use for testing our MSRV. See
https://blog.rust-lang.org/2023/08/29/committing-lockfiles for rationale
on this change.
@str4d
Copy link
Contributor Author

str4d commented Nov 29, 2023

Force-pushed to fix a copy-paste error.

Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@str4d str4d merged commit 003619b into main Nov 30, 2023
27 checks passed
@str4d str4d deleted the ci-updates branch November 30, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants