Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to sapling-crypto 0.3, orchard 0.10 #1554

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Migrate to sapling-crypto 0.3, orchard 0.10 #1554

merged 3 commits into from
Oct 2, 2024

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Oct 2, 2024

No description provided.

Cargo.toml Outdated Show resolved Hide resolved
nuttycom
nuttycom previously approved these changes Oct 2, 2024
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK with question

daira
daira previously approved these changes Oct 2, 2024
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.63%. Comparing base (3847cb2) to head (5d16a63).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1554      +/-   ##
==========================================
- Coverage   61.63%   61.63%   -0.01%     
==========================================
  Files         148      148              
  Lines       18821    18821              
==========================================
- Hits        11601    11600       -1     
- Misses       7220     7221       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@str4d str4d merged commit 9ef4117 into main Oct 2, 2024
27 of 28 checks passed
@str4d str4d deleted the dep-updates branch October 2, 2024 19:38
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

@@ -10,7 +10,8 @@ and this library adheres to Rust's notion of
## [0.17.0] - 2024-08-26

### Changed
- Update dependencies to `zcash_protocol 0.3.0`, `zcash_address 0.5.0`
- Update dependencies to `incrementalmerkletree 0.7`, `orchard 0.10`,
`sapling-crypto 0.3`, `zcash_protocol 0.3.0`, `zcash_address 0.5.0`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited the wrong part of the changelog here and it wasn't caught in review. I'll fix this in the release train PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants