-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directions: introduce driving directions support 🎉 #515
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Conflicts: # src/components/App/App.tsx
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Really nice - incredible! 🎉 🎉 Am I assuming correctly that Currently the distances show in miles / feet. Is this intended or based on the browser locale? |
@amenk - Thanks!! I think it was very much missing feature in OsmAPP even though it was not that hard to implement. No, brouter is not used at the moment – it is prepared in the code for an easy switch. I read that their main API is not to be used publicly, so I am waiting for their confirmation. Meanwhile we use Graphopper, which offers 500 routings/day which should be enough for OsmAPP currently. I think.. 🤔 You can change the units by clicking the Scale in the bottom left corner. It changes the units in the app as whole. This should really move to UserSettings! 😅 -> #572 |
Thanks. I understand that brouter is currently not used, but I was assuming that, if it's used it's only for bike routing. Did you also consider https://openrouteservice.org/plans/ ? They have bigger limits than GraphHopper and an official non-profit plan. |
I see the confusion now. If we switched handleRouting to BRouter, it would be used for all modes. The getPaint code only enhances the bike routes on BRouter to highlight steep ascents. I didn't implement elevation from Graphopper yet. I didn't know openrouteservice, thanks. That looks promising. I expect OsmAPP can easily implement more router engines and just let the user choose their favourites in some submenu. |
PREVIEW: live on https://osmapp.org
Waiting for a confirmation from BRouter API, until then the API used is Graphhopper freemium. In future there may be an option to choose preferred router and more routing profiles.
#31
TODO: