Food hygiene rating scheme

[Dlurak]

This PR would fix #110. I‘ve implemented it as stars and a as a featured tag just like the website or phone number.

Example: https://osmapp.org/way/193321876

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
osmapp	✅ Ready (Inspect)	Visit Preview	Aug 29, 2023 0:19am

[zbycz]

Hi @Dlurak, thanks for another great PR. 👋

[zbycz]

Could you please mock the fetchJson to return an example response?

jest
      .spyOn(fetch, 'fetchJson')
      .mockResolvedValue(`{ response json ... }`);

Also If the response format is usally the same, one example is enough.

We write unit tests to test our conversion functions. Your test would check if API is working correctly, but if it was down it would block our pipeline. Good rule is "unit tests must work offline".

It could be good to know if shape of their API changed, but this is not role of unit tests. We could have perhaps some "3rd party service status page" checking that.

[Dlurak]

So I changed it now, but I am not sure if it is right to have the entire API response or if it would be right to just have the relevant parts of the response.

[zbycz]

Yes, that is perfect. We call it fixtures, and its fine to have long JSONs in tests. This test isn't that much useful, but at least we know what other info is in that api call - for future reference.

✅

[zbycz]

This should be enough:

Suggested change

	const fhrsId = '269382';
	const rating = await getEstablishmentRatingValue(parseInt(fhrsId, 10));
	if (Number.isNaN(rating)) {
	expect(rating).toBeNaN();
	return;
	}
	expect(rating).toBeGreaterThanOrEqual(0);
	expect(rating).toBeLessThanOrEqual(5);
	const rating = await getEstablishmentRatingValue(423824);
	expect(rating).toBe(5);