Hide gardens without name #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zbycz
reviewed
Jul 25, 2022
| @@ -2884,6 +2766,7 @@ export const basicStyle = addHoverPaint({ | |||
| 'text-halo-color': 'rgba(255,255,255,0.8)', | |||
| }, | |||
| }, | |||
| ...poiLayers, | |||
There was a problem hiding this comment.
Thanks that you have abstracted it to the Poi-layers. I think they are used by both outdoor and basic style, so it is probably solved for both.
Also i think, that change like this one, should be rather carried out in OpenMapTiles repo. Because it doesnt really make sense to have it in the source-layer in the first place.
See https://github.com/openmaptiles/openmaptiles/tree/master/layers/poi
But until then, this is a good fix. Thank you for it!
zbycz
approved these changes
Jul 25, 2022
|
Wow, nice splitting it into two meaningful commits. I am feeling sorry to squash them :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.