Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): remove mypy from test action in favor of pre-commit action #1887

Merged
merged 1 commit into from
May 17, 2024
Merged

chore(ci): remove mypy from test action in favor of pre-commit action #1887

merged 1 commit into from
May 17, 2024

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented May 17, 2024 •
edited
Loading

closes #1788

cc @dstansby and @d-v-b

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@jhamman jhamman requested a review from d-v-b May 17, 2024 04:27
@jhamman jhamman changed the title chore(ci): remove mypy from test action in favor of pre-commit settings chore(ci): remove mypy from test action in favor of pre-commit action May 17, 2024
@dstansby
Copy link
Contributor

Seems sensible to me

d-v-b
d-v-b approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@d-v-b d-v-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved!

@jhamman jhamman merged commit ea2da93 into zarr-developers:v3 May 17, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanrz normanrz normanrz approved these changes

@d-v-b d-v-b d-v-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jhamman @dstansby @normanrz @d-v-b