Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some untyped calls #1865

Merged
merged 1 commit into from
May 12, 2024
Merged

Fix some untyped calls #1865

merged 1 commit into from
May 12, 2024

Conversation

dstansby
Copy link
Contributor

This fixes some untyped functions in zarr.common, which in turn fixes most of the untyped calls that now don't have to be ignored in pyproject.toml.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@jhamman jhamman merged commit 8da3df6 into zarr-developers:v3 May 12, 2024
18 checks passed
@dstansby dstansby deleted the fix-untyped-calls branch May 12, 2024 18:28
@jhamman jhamman added the V3 Affects the v3 branch label May 15, 2024
@jhamman jhamman added this to the 3.0.0.alpha milestone May 15, 2024
@jhamman jhamman added the types label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
types V3 Affects the v3 branch
Projects
Zarr-Python - 3.0
Status: Done
Milestone
3.0.0.alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@dstansby @jhamman