Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow untyped defs #1834

Merged
merged 2 commits into from
May 14, 2024
Merged

Disallow untyped defs #1834

merged 2 commits into from
May 14, 2024

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented May 3, 2024

More typing.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@dstansby dstansby mentioned this pull request May 3, 2024
Closed
16 tasks
@dstansby dstansby marked this pull request as ready for review May 3, 2024 17:45
@jhamman jhamman added the V3 Affects the v3 branch label May 7, 2024
@dstansby dstansby force-pushed the v3-disallow-untyped-defs- branch from 5584761 to 4995998 Compare May 7, 2024 10:16
@jhamman jhamman merged commit 5a39ff6 into zarr-developers:v3 May 14, 2024
18 checks passed
@dstansby dstansby deleted the v3-disallow-untyped-defs- branch May 14, 2024 08:43
@jhamman jhamman added this to the 3.0.0.alpha milestone May 15, 2024
@jhamman jhamman added the types label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
types V3 Affects the v3 branch
Projects
Zarr-Python - 3.0
Status: Done
Milestone
3.0.0.alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@dstansby @jhamman