Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add numpy 2 release candidate to test matrix #1828

Merged
merged 7 commits into from
May 6, 2024

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented May 2, 2024

closes #1818

cc @jakirkham

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@jakirkham
Copy link
Member

jakirkham commented May 2, 2024

Thanks Joe! 🙏

Looks good

Was trying to look in the CI logs to see where NumPy gets installed, but was having trouble seeing it. Do you know where this happens? Is that info just getting swallowed somewhere?

@jhamman
Copy link
Member Author

jhamman commented May 2, 2024

@jakirkham - your comment uncovered something in our new CI setup. We weren't passing the numpy version to the list of dependencies. That is fixed in this PR now.

Note: the test failures are in the v2 code path.

@maxrjones - could you take a look here and tell us if the features / version part of the matrix envs are getting picked up correctly?

features = ["optional"]

[tool.hatch.envs.test.scripts]
run-coverage = "pytest --cov-config=pyproject.toml --cov=pkg --cov=tests"
run = "run-coverage --no-cov"
run-verbose = "run-coverage --verbose"
run-mypy = "mypy src"
list-env = "pip list"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is used in the test github action

Comment on lines +95 to +97
dependencies = [
"numpy~={matrix:numpy}",
]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was what we were missing. Eeek!

@jakirkham
Copy link
Member

your comment uncovered something in our new CI setup. We weren't passing the numpy version to the list of dependencies. That is fixed in this PR now.

Sounds like a productive exercise then 🙂

Thanks Joe! 🙏

@maxrjones
Copy link
Member

@maxrjones - could you take a look here and tell us if the features / version part of the matrix envs are getting picked up correctly?

The only dependency that is different between minimal and optional is lmdb which is also included in the extra-dependencies for the tests env, meaning the features part of the matrix is not currently doing anything. If you're willing to clarify which deps should be including in only optional I can fix that part of the setup.

@jakirkham
Copy link
Member

Looking good. Thanks Joe! 🙏

Can see NumPy 2.0.0rc1 getting installed and CI passing 🎉

@jhamman jhamman merged commit 19a28df into zarr-developers:v3 May 6, 2024
18 checks passed
@jhamman jhamman mentioned this pull request May 6, 2024
3 tasks
@jakirkham jakirkham mentioned this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants