Disallow untyped calls #1811
Merged
Disallow untyped calls #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamman
approved these changes
Apr 24, 2024
| [[tool.mypy.overrides]] | ||
| module = [ | ||
| "zarr.v2._storage.store", | ||
| "zarr.v2._storage.v3_storage_transformers", | ||
| "zarr.v2.*", |
|
@dstansby - mind sorting the conflict here? |
dstansby
force-pushed
the
v3-typing-untyped-defs
branch
from
dc0e7a8
to
656283e
Compare
|
👍 done |
dstansby
force-pushed
the
v3-typing-untyped-defs
branch
from
656283e
to
c77f348
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tightens up mypy again, disallowing untyped calls. As with other PRs I made some simple fixes, and put the more complex sub-modules in a list to ignore this error which we can fix one at a time in subsequent PRs.