implement __eq__ for LocalStore #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check untyped defs (zarr-developers#1784)
Fix equality comparison in LocalStore class by implementing __eq__ method
d-v-b
reviewed
Apr 13, 2024
|
@Charoula-Kyriakides thanks for the contribution! It might be good to have some more information in the title and description of the PR. I can fill those in if you like. |
|
That'd be great, thanks. I'm still learning. Should it be something similar
to the commit message?
…On Sat, 13 Apr 2024, 12:41 Davis Bennett, ***@***.***> wrote:
@Charoula-Kyriakides <https://github.com/Charoula-Kyriakides> thanks for
the contribution! It might be good to have some more information in the
title and description of the PR. I can fill those in if you like.
—
Reply to this email directly, view it on GitHub
<#1792 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWETG7M5S7JRTSSWYE4XALDY5EKWPAVCNFSM6AAAAABGE7GSO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJTGYZDCOBWHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Maybe something simple like "implement |
Changed 'LocalStore' to object in __eq__ Co-authored-by: Davis Bennett <davis.v.bennett@gmail.com>
d-v-b
approved these changes
Apr 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement eq for LocalStore