Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dmypy to be run on v3 branch #1780

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Apr 9, 2024

This allows dmypy, the mypy daemon to be run on the v3 branch. In turn this allows the mypy plugin to be used in VSCode.

follow_imports is not supported by the daemon, but not needed, and namespace_packages = false is needed so mypy doesn't interpret src/ as a package.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@MSanKeys963 MSanKeys963 added the V3 Affects the v3 branch label Apr 9, 2024
@d-v-b d-v-b merged commit 3a73950 into zarr-developers:v3 Apr 11, 2024
14 checks passed
@dstansby dstansby deleted the dmypy branch April 11, 2024 18:49
@jhamman jhamman added this to the 3.0.0.alpha milestone Apr 22, 2024
@jhamman jhamman added the types label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
types V3 Affects the v3 branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants