Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create hatch test env #1650

Merged
merged 6 commits into from
Feb 6, 2024
Merged

create hatch test env #1650

merged 6 commits into from
Feb 6, 2024

Conversation

rabernat
Copy link
Contributor

@rabernat rabernat commented Feb 6, 2024

Closes #1648

@d-v-b d-v-b marked this pull request as ready for review February 6, 2024 17:25
@d-v-b
Copy link
Contributor

d-v-b commented Feb 6, 2024

anything I should wait on before merging?

@rabernat rabernat marked this pull request as draft February 6, 2024 17:27
@rabernat
Copy link
Contributor Author

rabernat commented Feb 6, 2024

Lots! I am not done here. I thought this was a draft.

I'd like to get to a working GH action using the hatch test env.

@jhamman
Copy link
Member

jhamman commented Feb 6, 2024

This did not run the test -- why is that?

@rabernat
Copy link
Contributor Author

rabernat commented Feb 6, 2024

Because tests only run on main. We will need to completely redo the test environment using hatch. I intend to have an MPV version of that in a new workflow file as part of this PR.

@d-v-b
Copy link
Contributor

d-v-b commented Feb 6, 2024

Lots! I am not done here. I thought this was a draft.

I'd like to get to a working GH action using the hatch test env.

Oops, I didn't see the draft tag. I got too excited!

@rabernat rabernat marked this pull request as ready for review February 6, 2024 20:14
@rabernat rabernat requested a review from d-v-b February 6, 2024 20:14
d-v-b
d-v-b approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@d-v-b d-v-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! in future PRs we can lean more into the configuration, but I love what we have already

@d-v-b d-v-b merged commit 644423c into zarr-developers:v3 Feb 6, 2024
7 checks passed
This was referenced Feb 6, 2024
Open
Open
@jhamman jhamman added the V3 Affects the v3 branch label Apr 22, 2024
@jhamman jhamman added this to the 3.0.0.alpha milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-v-b d-v-b d-v-b approved these changes

Assignees
No one assigned
Labels
V3 Affects the v3 branch
Projects
Zarr-Python - 3.0
Status: Done
Milestone
3.0.0.alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@rabernat @d-v-b @jhamman