Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap v3 branch with zarrita #1584

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Bootstrap v3 branch with zarrita #1584

merged 5 commits into from
Dec 5, 2023

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Nov 29, 2023

This PR begins taking steps toward the design described in #1583 and is intended to bootstrap the v3 development branch (note that this PR does not point at main). There is a lot more to do here but this felt like a decent starting point.

This branch is not yet wired up to the test suite so coverage, documentation checks are all expected to fail.

At this point, I've specifically taken the following steps:

  1. Copied Zarrita at scalableminds/zarrita@7827478 into the v3 directory
  2. applied Zarr-Python's linter rules
  3. renamed zarrita -> v3
  4. Added some (but not all) ABCs
  5. Begin to incorporate these ABCs, mostly in the Array classes.

Pending some feedback from @normanrz and @d-v-b, my proposal is that we move to merge this into the v3 branch without much more work here. From there, we can start peeling small bits off of the design mentioned above.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@pep8speaks
Copy link

Hello @jhamman! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 100:87: E203 whitespace before ':'
Line 114:48: E203 whitespace before ':'

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Nov 29, 2023
@jhamman jhamman merged commit b4c2a19 into zarr-developers:v3 Dec 5, 2023
5 of 6 checks passed
@jhamman jhamman mentioned this pull request Dec 7, 2023
2 tasks
jhamman added a commit to jhamman/zarr-python that referenced this pull request Jan 24, 2024
* Pull Zarrita into Zarr-Python @ 78274781ad64aef95772eb4b083f7ea9b7d03d06

No code changes to Zarrita were made.

* apply zarr lint rules

* zarrita -> v3

* v3/abc [wip]

* use abcs plus implementation notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants