Fix normalize_fill_value
for structured arrays
#1397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FutureWarning identified in #552 is now a
TypeError
in the latest numpy release. We can fix this bu checking whetherisinstance(fill_value, np.void)
before checking whetherfill_value == 0
(that way, iffill_value
is already a structured dtype, then we do not compare it with a scalar).One symptom of this is that
will crash with
Closes #552.