This repository has been archived by the owner on Feb 12, 2023. It is now read-only.
feat: produce CIDv1 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures produced CIDs are more deterministic and future-proof. Producing CIDv1 ensures the text representation looks the same on subdomain gateways and in browser address bar.
|
Thanks @lidel, I agree that we should totally do this 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures produced CIDs are more deterministic and future-proof.
Rationale
We should avoid CIDv0 in blockchain contexts because it means people can cut corners and code against Multihash spec instead of CID spec.
Producing CIDv1 removes ambiguity and ensures people write things in a future-proof way.
Also, UX is better:
@yusefnapora I also included
hashAlgto be immune from changes to the default behavior ofipfs add, but feel free to remove it if you feel its an overkill.