Add Text() retrieval for BaseBlock types #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation was missing, making it impossible to retrieve Text from block types, such as CodeBlock and FencedCodeBlock, via the ast interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use the ast to parse code blocks, and noticed that
Text()was always returning empty data.After digging into this a bit I discovered that the
BaseNodetype only retrieves Text from child nodes. However, theBaseBlocktype (used for code and fenced code blocks) does not have children. Instead, it needs its ownText()implementation to enumerateLines()to retrieve the text segment(s) identified during parsing.If you would like to verify that the code change resolves the issue, please comment out the new code in
ast/block.goand run the tests.I've also verified this fix against the test program included in #459.
Thanks!
Closes #459