Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate names for exercises #3

Closed
IgnisDa opened this issue Jun 24, 2023 · 4 comments
Closed

Alternate names for exercises #3

IgnisDa opened this issue Jun 24, 2023 · 4 comments

Comments

@IgnisDa
Copy link

IgnisDa commented Jun 24, 2023

Thanks for this really helpful project!

I am trying to port a workout dump that uses exercises from ExerciseDB. Since most of the exercises have a different name here, it is quite difficult to do so. I suggest we add a new key to each exercise called alternateNames: string[]. This will allow others users to port their own data to this dataset more easily.

I can make a PR for the same.

@yuhonas
Copy link
Owner

yuhonas commented Jun 26, 2023

Hey, glad it's been helpful! sounds totally reasonable, My hope was that we could use a single canonical name but in the real world that's probably a little too much to ask for 😆 out of interest have you got some examples?

@IgnisDa
Copy link
Author

IgnisDa commented Jun 26, 2023

I have added link to a dataset above, most exercises have a different name as to what this database has.

@yuhonas
Copy link
Owner

yuhonas commented Jun 27, 2023

I see, happy for you to push up a PR!

@IgnisDa
Copy link
Author

IgnisDa commented Oct 14, 2023

Hello. Sorry, I never was able to do it since it was taking too much effort. However, since then, I have created a mapping of around 200 exercises from exerciseDb to this project for my own project.

I have written down some instructions here. Maybe it will be helpful to someone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants