[bbc] Extract more metadata for window.__INITIAL_DATA__ pages #28774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstftw
requested changes
Apr 17, 2021
dstftw
requested changes
Apr 17, 2021
dirkf
force-pushed
the
df-initialmetadata-patch
branch
from
8daae22
to
9f6c03a
Compare
|
Weirdly the changes were overwritten, but now restored, |
ext and upload_date are required
|
Thanks for your work, Sergey. |
dstftw
added a commit
that referenced
this pull request
Apr 20, 2021
github-actions bot
added a commit
to hellopony/youtube-dl
that referenced
this pull request
Apr 21, 2021
* https://github.com/ytdl-org/youtube-dl: [youtube] Remove unused code [go] Improve video id extraction (closes ytdl-org#25207, closes ytdl-org#25216, closes ytdl-org#26058) [test_execution] Add test for lazy extractors (refs ytdl-org#28780) [test_youtube_misc] Move YoutubeIE.extract_id test into separate module [youtube] Fix lazy extractors (closes ytdl-org#28780) [bbc] Extract full description from __INITIAL_DATA__ (refs ytdl-org#28774) [bbc] Extract description and timestamp from __INITIAL_DATA__ (ytdl-org#28774)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Pages with metadata extracted from a JSON object assigned to window.INITIAL_DATA didn't extract timestamp and description. At least for the type where the metadata is in the
media-experienceobject, this PR adds those items.Examples: