-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump non minimal testing infra from python 3.8 to 3.9 #2978
Bump non minimal testing infra from python 3.8 to 3.9 #2978
Conversation
Note: according to https://github.com/numpy/numpy/releases, the first numpy version which supports Python 3.9 AND has binary wheels on all platform is numpy 1.19.3 with cython>=0.29.21. I would recommend using this combination on Python 3.9. |
09f28bf
to
25c252b
Compare
Thanks Corentin for your support. There are still a lot of failures (version conflicts) at least for the windows build. I'm going to switch it off momentarily to see wether we can at least get the builds to work on UNIX |
c7e6060
to
03d8a41
Compare
Progress report:
Overall it seems that the environment is still not ripe for this change, but this PR is a good place to keep checking and have it ready asap. |
note: h5py 3.0 should be compatible with Python 3.6, but it's unclear wether 3.9 is supported atm.
I'll try bumping this later but for now I'm just bumping scipy to see what happens. |
So bumping scipy and pyqt5 to their respective latest versions works, but maybe only because they come with wheels for python 3.9 already. It seems likely that earlier versions may be distributed in the future, but in the meantime, windows is the bottleneck here. |
Why would pyqt5 affect answers? We're using Agg backend after all. |
Whenever you need newer version of a package for py3.9 you could add the following to requirements.txt:
|
I don't know, but that's actually what happened on the commit I did nothing else than bumping PyQt5 ! |
Good to know ! I'll try to avoid this as much as possible to minimise the complexity of our requirements though, but it can indeed come in handy as a last resort. |
Can you re-enable them? They didn't fail on jenkins with PyQt5-5.15.2. It might have been a fluke. |
sure thing ! |
Actually it's just a single failure, I was expecting a lot more ! |
c04d642
to
84b6d65
Compare
I opened a related issue for scipy scipy/scipy#13145 edit: now awaiting this issue conda-forge/scipy-feedstock#149 |
2ae29a7
to
90e166b
Compare
5f88472
to
3670215
Compare
3670215
to
1428a0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That all looks reasonable to me, though I cannot tell whether the changes look are minimal or not.
So what do we think, is this controversial? |
They probably aren't, to be honest. I find that searching manually for minimal compatible versions is terribly inefficient, but as I'm not bumping edit: dowstream -> upstream |
e4dd548
to
a107169
Compare
Interestingly, pre-commit.ci failed and forgot to append a commit... reporting this upstream ! |
d62bef2
to
594cfed
Compare
…s.txt to further support building against python 3.9
594cfed
to
889c8ed
Compare
@yt-fido test this please |
todo: