Skip to content

Commit

Permalink
ci: bump minimal test infra to match Python 3.7
Browse files Browse the repository at this point in the history
  • Loading branch information
neutrinoceros committed Nov 23, 2020
1 parent a6a06bc commit da2bc1c
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 6 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/build-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ jobs:
dependencies: [full]
tests-type: [unit]
include:
- os: ubuntu-18.04
python-version: 3.7
dependencies: minimal
tests-type: unit
- os: ubuntu-18.04
python-version: 3.7
dependencies: full
Expand Down
13 changes: 7 additions & 6 deletions tests/ci_install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,14 @@ fi

# Step 2: install required packages (depending on whether the build is minimal)
if [[ ${dependencies} == "minimal" ]]; then
# Ensure numpy and cython are installed so dependencies that need to be built
# don't error out
# The first numpy to support py3.6 is 1.12, but numpy 1.13 matches
# unyt so we'll match it here.
# Ensure numpy and cython are installed so dependencies that need to
# be built don't error out.

# TODO: UPDATE THIS TO TARGET PYTHON 3.7 AS MINIMAL
python -m pip install numpy==1.13.3 cython==0.26.1
# numpy 1.16.0 is the first feature release to support Python 3.7
# We'll use the last bugfix release in the series as minimal here.
# The corresponding release notes recommend compiling with cython>=0.29.2
# https://github.com/numpy/numpy/releases/tag/v1.16.6
python -m pip install numpy==1.16.6 cython==0.29.2
python -m pip install -r tests/test_minimal_requirements.txt
else
# Getting cartopy installed requires getting cython and numpy installed
Expand Down

0 comments on commit da2bc1c

Please sign in to comment.