Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance yorc metrics (especially operation execution) to make them more "parseable" #507

Open
fcdenos opened this issue Sep 2, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@fcdenos
Copy link

fcdenos commented Sep 2, 2019

Is your feature request related to a problem? Please describe.
The yorc metrics returned by /yorc_metrics URL could be more usable if we could have another syntax than this type :
yorc_executor_operation_WXC_PERIMETRE_TIERS_HOB_SECLIN_sg_nodes_PrometheusAgent_standard_create_sum

Describe the solution you'd like
Instead of the syntax above, it would be better for automated parsing and analysis to have something like :
yorc_executor_operation{deployment=WXC_PERIMETRE_TIERS_HOB_SECLIN}{type=sg_nodes_PrometheusAgent}{operation=standard_create}_sum

@fcdenos fcdenos added the enhancement New feature or request label Sep 2, 2019
@loicalbertin
Copy link
Member

@fcdenos we plan to refactor the metrics in 4.0 cycle (see #297).
We will take advantage of the labels mechanism it will be more Prometheus-friendly.

@adidanes
Copy link
Contributor

adidanes commented Dec 9, 2019

Hi @fcdenos,

Can you take a look to the PR : #569.

For the metric example that you provided, it should be identified like this:

yorc_executor_operation{Deployment="WXC_PERIMETRE_TIERS_HOB_SECLIN", Node="sg_nodes_PrometheusAgent", Name="standard_create"}

@fcdenos
Copy link
Author

fcdenos commented Dec 14, 2019

Hi @adidanes,
It seems to fulfill our needs, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants