Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for Block stories to define "MobileLayout" #33

Open
fabiankaegy opened this issue Aug 7, 2020 · 2 comments
Open

Allow for Block stories to define "MobileLayout" #33

fabiankaegy opened this issue Aug 7, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fabiankaegy
Copy link
Collaborator

It would be cool to have an additional parameter when creating a BlockStory to allow to create stories for Mobile as well as Desktop.

I'm not sure wether we should just have a Boolean to toggle between mobile & Desktop, have an array of different possible screen sizes or just pass through the viewportWidth to the BlockPreview component.
@fabiankaegy fabiankaegy added enhancement New feature or request good first issue Good for newcomers labels Aug 7, 2020
@youknowriad
Copy link
Owner

What if instead, we add a device switcher you can use in both "example", "editor" and "stories" tabs?

@fabiankaegy
Copy link
Collaborator Author

From a users perspective I like that 👍
From a Developer perspective it would mean that you have to switch between the modes constantly and can't see both at the same time. I'm wondering wether there is anything where we would get both benefits. But the usability of having the switcher makes more sense I thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@youknowriad @fabiankaegy