Added hickory-dns feature for auth and storage #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshidan
reviewed
Apr 23, 2024
.gitignore
Outdated
| @@ -9,6 +9,7 @@ Cargo.lock | |||
| # These are backup files generated by rustfmt | |||
| **/*.rs.bk | |||
|
|
|||
| /.idea | |||
There was a problem hiding this comment.
Could you remove /.idea because IDE is different for each person. Please set it in your own gitignore_global.
There was a problem hiding this comment.
Reverted .gitignore, and also added a hickory-dns feature for bigquery crate.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default DNS resolver doesn't work in some environment, for example, when using rustls in a linux docker container, but using
hickory-dnsfeature worked.