Update reqwest Dependency to Version 0.12.0 in google-cloud-storage Client (#251) #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshidan
reviewed
Apr 22, 2024
foundation/auth/Cargo.toml
Outdated
| @@ -11,7 +11,7 @@ description = "Google Cloud Platform server application authentication library." | |||
|
|
|||
| [dependencies] | |||
| tracing = "0.1" | |||
| reqwest = { version = "0.11", features = ["json"], default-features = false } | |||
| reqwest = { version = "0.12.4", features = ["json"], default-features = false } | |||
There was a problem hiding this comment.
charset feature is required to use text_with_charset at 0.12.4
https://docs.rs/reqwest/0.12.4/reqwest/struct.Response.html#method.text_with_charset
There was a problem hiding this comment.
I added this feature to foundation/auth/Cargo.toml.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses the issue #251, "Request for Migration to reqwest ^0.12.0 in google-cloud-storage Dependency". I have forked the repository, created a new branch, and made the necessary changes to update the reqwest dependency to version 0.12.0 within the google-cloud-storage client.
Changes Made:
Additional Notes:
I have ensured that the changes only affect the request dependencies within the storage client and have not made any unrelated modifications to the other crates. While I couldn't perform local testing please test these changes in the project environment.
Request for Review:
I kindly request the maintainer to review these changes and consider merging them into the main repository. Thank you for your attention to this matter. I am open to any feedback or suggestions for improvement.
Best regards,
Len