Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request middleware to BQ #231

Merged
merged 1 commit into from
Feb 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bigquery/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ base64 = "0.21"
bigdecimal = { version="0.3", features=["serde"] }
num-bigint = "0.4"
backon = "0.4"
reqwest-middleware = "0.2"
anyhow = "1.0"

google-cloud-auth = { optional = true, version = "0.13", path="../foundation/auth", default-features=false }

Expand Down
6 changes: 3 additions & 3 deletions bigquery/src/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const JOB_RETRY_REASONS: [&str; 3] = ["backendError", "rateLimitExceeded", "inte

#[derive(Debug)]
pub struct ClientConfig {
http: reqwest::Client,
http: reqwest_middleware::ClientWithMiddleware,
bigquery_endpoint: Cow<'static, str>,
token_source_provider: Box<dyn TokenSourceProvider>,
environment: Environment,
Expand Down Expand Up @@ -65,7 +65,7 @@ impl ClientConfig {
grpc_token_source_provider: Box<dyn TokenSourceProvider>,
) -> Self {
Self {
http: reqwest::Client::default(),
http: reqwest_middleware::ClientBuilder::new(reqwest::Client::default()).build(),
bigquery_endpoint: "https://bigquery.googleapis.com".into(),
token_source_provider: http_token_source_provider,
environment: Environment::GoogleCloud(grpc_token_source_provider),
Expand All @@ -81,7 +81,7 @@ impl ClientConfig {
self.streaming_read_config = value;
self
}
pub fn with_http_client(mut self, value: reqwest::Client) -> Self {
pub fn with_http_client(mut self, value: reqwest_middleware::ClientWithMiddleware) -> Self {
self.http = value;
self
}
Expand Down
10 changes: 8 additions & 2 deletions bigquery/src/http/bigquery_client.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use std::sync::Arc;

use reqwest::{Client, RequestBuilder, Response};
use reqwest::Response;
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

use google_cloud_token::TokenSource;

Expand Down Expand Up @@ -139,7 +140,12 @@ pub(crate) mod test {
.unwrap();
let cred = tsp.source_credentials.clone();
let ts = tsp.token_source();
let client = BigqueryClient::new(ts, "https://bigquery.googleapis.com", reqwest::Client::new(), false);
let client = BigqueryClient::new(
ts,
"https://bigquery.googleapis.com",
reqwest_middleware::ClientBuilder::new(reqwest::Client::new()).build(),
false,
);
(client, cred.unwrap().project_id.unwrap())
}

Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/dataset/delete.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

pub fn build(base_url: &str, client: &Client, project_id: &str, dataset_id: &str) -> RequestBuilder {
let url = format!("{}/projects/{}/datasets/{}", base_url, project_id, dataset_id);
Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/dataset/get.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

pub fn build(base_url: &str, client: &Client, project_id: &str, dataset_id: &str) -> RequestBuilder {
let url = format!("{}/projects/{}/datasets/{}", base_url, project_id, dataset_id);
Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/dataset/insert.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

use crate::http::dataset::Dataset;

Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/dataset/list.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use std::collections::HashMap;

use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

use crate::http::dataset::DatasetReference;

Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/dataset/patch.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

use crate::http::dataset::Dataset;

Expand Down
13 changes: 13 additions & 0 deletions bigquery/src/http/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,24 @@ pub enum Error {
#[error(transparent)]
HttpClient(#[from] reqwest::Error),

/// An error from the HTTP client.
#[error(transparent)]
HttpMiddleware(anyhow::Error),

/// An error from a token source.
#[error("token source failed: {0}")]
TokenSource(Box<dyn std::error::Error + Send + Sync>),
}

impl From<reqwest_middleware::Error> for Error {
fn from(error: reqwest_middleware::Error) -> Self {
match error {
reqwest_middleware::Error::Reqwest(err) => Error::HttpClient(err),
reqwest_middleware::Error::Middleware(err) => Error::HttpMiddleware(err),
}
}
}

#[derive(Debug, serde::Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct ErrorResponse {
Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/job/cancel.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use reqwest::header::CONTENT_LENGTH;
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

use crate::http::job::Job;

Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/job/delete.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

pub fn build(base_url: &str, client: &Client, project_id: &str, job_id: &str) -> RequestBuilder {
let url = format!("{}/projects/{}/jobs/{}", base_url, project_id, job_id);
Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/job/get.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

#[derive(Clone, PartialEq, serde::Deserialize, serde::Serialize, Debug, Default)]
#[serde(rename_all = "camelCase")]
Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/job/get_query_results.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

use crate::http::job::JobReference;
use crate::http::table::TableSchema;
Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/job/insert.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

use crate::http::job::Job;

Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/job/list.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

use crate::http::job::{JobConfiguration, JobReference, JobState, JobStatistics, JobStatus};
use crate::http::types::ErrorProto;
Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/job/query.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use std::collections::HashMap;

use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

use crate::http::dataset::DatasetReference;
use crate::http::job::{DmlStats, JobReference, SessionInfo};
Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/model/delete.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

pub fn build(base_url: &str, client: &Client, project_id: &str, dataset_id: &str, model_id: &str) -> RequestBuilder {
let url = format!(
Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/model/get.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

pub fn build(base_url: &str, client: &Client, project_id: &str, dataset_id: &str, model_id: &str) -> RequestBuilder {
let url = format!(
Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/model/list.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

use crate::http::model::{ModelReference, ModelType};

Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/model/patch.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

use crate::http::model::Model;

Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/routine/delete.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

pub fn build(base_url: &str, client: &Client, project_id: &str, dataset_id: &str, routine_id: &str) -> RequestBuilder {
let url = format!(
Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/routine/get.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

pub fn build(base_url: &str, client: &Client, project_id: &str, dataset_id: &str, routine_id: &str) -> RequestBuilder {
let url = format!(
Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/routine/insert.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

use crate::http::routine::Routine;

Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/routine/list.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

use crate::http::routine::{Language, RemoteFunctionOptions, RoutineReference, RoutineType};

Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/routine/update.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

use crate::http::routine::Routine;

Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/row_access_policy/get_iam_policy.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

use crate::http::table::get_iam_policy::GetIamPolicyRequest;

Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/row_access_policy/list.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};
use time::OffsetDateTime;

use crate::http::row_access_policy::RowAccessPolicyReference;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

use crate::http::table::test_iam_permissions::TestIamPermissionsRequest;

Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/table/delete.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

pub fn build(base_url: &str, client: &Client, project_id: &str, dataset_id: &str, table_id: &str) -> RequestBuilder {
let url = format!(
Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/table/get.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

pub fn build(base_url: &str, client: &Client, project_id: &str, dataset_id: &str, table_id: &str) -> RequestBuilder {
let url = format!(
Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/table/get_iam_policy.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

use crate::http::types::GetPolicyOptions;

Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/table/insert.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

use crate::http::table::Table;

Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/table/list.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

use crate::http::table::{Clustering, RangePartitioning, TableReference, TimePartitioning};

Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/table/patch.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

use crate::http::table::Table;

Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/table/set_iam_policy.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

use crate::http::types::Policy;

Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/table/test_iam_permissions.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

#[derive(Clone, PartialEq, Eq, serde::Deserialize, serde::Serialize, Default, Debug)]
#[serde(rename_all = "camelCase")]
Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/tabledata/insert_all.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};
use serde::Serialize;

#[derive(Clone, PartialEq, Eq, serde::Deserialize, serde::Serialize, Debug)]
Expand Down
2 changes: 1 addition & 1 deletion bigquery/src/http/tabledata/list.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use std::fmt::Debug;

use reqwest::{Client, RequestBuilder};
use reqwest_middleware::{ClientWithMiddleware as Client, RequestBuilder};

#[derive(Clone, PartialEq, Eq, serde::Deserialize, serde::Serialize, Debug)]
#[serde(untagged)]
Expand Down
2 changes: 1 addition & 1 deletion storage/src/http/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ pub enum Error {

/// An error from one of the middleware used.
#[error(transparent)]
HttpMiddleware(#[from] anyhow::Error),
HttpMiddleware(anyhow::Error),

/// An error from a token source.
#[error("token source failed: {0}")]
Expand Down
Loading