feat: bump angular 17 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yociduo
reviewed
Nov 29, 2023
package.json
Outdated
| "@angular/platform-browser": "^16.0.0", | ||
| "@angular/platform-browser-dynamic": "^16.0.0", | ||
| "@angular/router": "^16.0.0", | ||
| "@angular-devkit/core": "^17.0.1", |
There was a problem hiding this comment.
Please using the same version for angular such as the 17.0.0
yociduo
force-pushed
the
feat/87
branch
2 times, most recently
from
5a2e3f0
to
fa1d75d
Compare
|
@damingerdai I have removed the node 16 support and fixed the typo for pendo. The CI still failed, please check. By the way, I have cherry pick the remove node 16 support, if you do something, please rebase your branch firstly |
|
@yociduo please review |
yociduo
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #87