Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include=FALSE should imply stop_on_error=2 for that chunk #453

Closed
jpritikin opened this issue Jan 6, 2013 · 4 comments
Closed

include=FALSE should imply stop_on_error=2 for that chunk #453

jpritikin opened this issue Jan 6, 2013 · 4 comments
Milestone
v1.0

Comments

@jpritikin
Copy link

Otherwise there is no indication that an error occurred. It took me an hour to figure out what was going on.
@yihui
Copy link
Owner

yihui commented Jan 6, 2013

I understand the frustration, and sorry about that. I have been thinking about the decision on the default value of stop_on_error. Maybe I'll change it to 2 by default, since 0 may surprise some people.

@jpritikin
Copy link
Author

If you don't want to make stop_on_error vary per chunk, then yeah, make it 2 by default and explain how to switch it to zero. I can see the benefit of setting it to zero too. I just want to switch it deliberately so I am prepared.

@yihui yihui closed this as completed in 450e38c Jan 7, 2013
@yihui
Copy link
Owner

yihui commented Jan 7, 2013

fixed now

@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@yihui @jpritikin