Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty write_bib() for packages without URL #2304

Closed
bastistician opened this issue Oct 30, 2023 · 2 comments
Closed

empty write_bib() for packages without URL #2304

bastistician opened this issue Oct 30, 2023 · 2 comments
Assignees
Labels
bug Bugs

Comments

@bastistician
Copy link
Contributor

To reproduce, call write_bib() for an installed package with no URL in its DESCRIPTION, for example:

knitr::write_bib("gridSVG")

currently produces nothing but an empty line.
This is a regression in knitr 1.44 due to #2264.
The return logic in

if (is.null(meta$URL)) return(meta)

seems at fault.

@yihui yihui self-assigned this Oct 30, 2023
@yihui yihui closed this as completed in ce8cf77 Oct 30, 2023
@yihui
Copy link
Owner

yihui commented Oct 30, 2023

Should be fixed now. Thanks for the report! Too bad I didn't catch it sooner since I just made a CRAN release yesterday.

@yihui yihui added the bug Bugs label Oct 30, 2023
Copy link

github-actions bot commented May 1, 2024

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bugs
Projects
None yet
Development

No branches or pull requests

2 participants