Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A number of fixes for compiler warnings #20

Merged
merged 15 commits into from
Jun 1, 2016
Merged

A number of fixes for compiler warnings #20

merged 15 commits into from
Jun 1, 2016

Conversation

hvellyr
Copy link
Contributor

@hvellyr hvellyr commented Jun 1, 2016

Since I'm considering using this code in an environment which has much stricter warnings level set, I found quite a number of places to improve the code. To achieve this I propose some CMake enhancement plus automatic testing on travis-ci.org. (Unluckily llvm.org decided to drop their apt download which makes building with clang on linux boxes on travis-ci.org fail currently).

@yhirose yhirose merged commit 23a827d into yhirose:master Jun 1, 2016
@yhirose
Copy link
Owner

yhirose commented Jun 1, 2016

@hvellyr, thanks for the valuable contribution!
As you mentioned, the test with clang on travis-ci.org failed. (https://travis-ci.org/yhirose/cpp-peglib/jobs/134591902)
Do you think that they will fix it soon, or the dropping apt support is permanent?

@gck-ableton
Copy link

Hi, I can't imagine that this outage will stay permanently. Wether llvm.org opens their apt download again, or that service is hosted somewhere else, I don't know. It's basically all a problem about travis using too old ubuntu versions (default is 12.02 I think), where clang is still a 3.4 (or so) with limited c++11 support.

I wanted to experiment with a different base version (trusty seems to be available in travis, i.e. 14.04), but didn't had the time to do so. Alternatively one could turn off the container support (i.e. sudo: true) and install a clang from there.

Since a lot of projects are affected by this outage I'm pretty someone will come up with some solution. For now best is probably to disable clang 😞

(BTW. The "official" issue with the travis whitelist is here travis-ci/apt-source-safelist#156)

@yhirose
Copy link
Owner

yhirose commented Jun 2, 2016

Thanks for the info. I disabled the clang section for now, and added the travis-ci build status badge on README. It's great to see the green 'passing' badge!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants