-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add test for tabs in no-extra-spacing-attrs #202
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1222ffc
Add disallowTabs
RobertAKARobin fa96fce
Add unexpectedBeforeClose
RobertAKARobin b4b9b3f
Update docs
RobertAKARobin 32cdbfc
prettier
RobertAKARobin d67e47b
De-nesting some if statements
RobertAKARobin 8a89536
Fix tests for multiline cases
RobertAKARobin 37120a0
Prettier
RobertAKARobin feb561e
Fix using col instead of range
RobertAKARobin ea6e983
Add another multiline test case
RobertAKARobin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved this logic into the
return { [Tag](node){} }
function because otherwise I found that we were recalculating several variables that had already been calculated, and it also let me present the logic in a more linear way that I found easier to understand. This did result in one existing test being changed slightly... See https://github.com/yeonjuan/html-eslint/pull/202/files#diff-dc2d2c159cee6aaa292bf260ddb4613296b2d20c77543ba6c0705e29ed1a993eR312. I hope that's OK!