feat: skip check when html tag does not exists (#154)

yeonjuan · Nov 1, 2023 · 952917f · 952917f
1 parent aba345c
commit 952917f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 27 deletions.
diff --git a/packages/eslint-plugin/lib/rules/require-doctype.js b/packages/eslint-plugin/lib/rules/require-doctype.js
@@ -34,7 +34,10 @@ module.exports = {
       Doctype() {
         hasDocType = true;
       },
-      "Program:exit"(node) {
+      "Tag:exit"(node) {
+        if (node.name !== "html") {
+          return;
+        }
         if (!hasDocType) {
           context.report({
             node,

diff --git a/packages/eslint-plugin/tests/rules/require-doctype.test.js b/packages/eslint-plugin/tests/rules/require-doctype.test.js
@@ -12,6 +12,11 @@ ruleTester.run("require-doctype", rule, {
 </html>
 `,
     },
+    {
+      code: `
+<div></div>
+      `,
+    },
   ],
   invalid: [
     {
@@ -23,32 +28,6 @@ ruleTester.run("require-doctype", rule, {
 </html>
 `,
 
-      errors: [
-        {
-          messageId: "missing",
-        },
-      ],
-    },
-    {
-      code: `<body>
-</body>
-`,
-      output: `<!DOCTYPE html>
-<body>
-</body>
-`,
-
-      errors: [
-        {
-          messageId: "missing",
-        },
-      ],
-    },
-    {
-      code: ``,
-      output: `<!DOCTYPE html>
-`,
-
       errors: [
         {
           messageId: "missing",