Put build artifact tracking in integrity file #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestander
approved these changes
Apr 22, 2017
| @@ -329,6 +329,12 @@ export class Install { | |||
| return true; | |||
| } | |||
|
|
|||
| const {artifacts} = match; | |||
There was a problem hiding this comment.
Is it the right place?
bailout() function is overridden in add.js.
In the next couple of weeks I'd like to do integrity check earlier in install phase.
| @@ -247,6 +251,7 @@ export default class InstallationIntegrityChecker { | |||
| integrityFileMissing: false, | |||
| integrityMatches, | |||
| missingPatterns, | |||
| artifacts: expected ? expected.artifacts : null, | |||
There was a problem hiding this comment.
Returning artifacts from check seems to break cohesion of the check function.
Makes sense from performance point of view because we already parse integrity file here but I would rather have a separate function that returns integrity file.
Side note: my fault that check command has side effects (reporter logs), I plan to refactor it.
|
Let's merge it now, I'll be refactoring integrity-checker next week |
This was referenced Apr 24, 2017
Closed
This was referenced Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This moves build artifact tracking away from the cache metadata and into the integrity file.
I suspect this should fix #1981 as the cause seems to be that they restore
node_modulesand not Yarn's internal cache.Test plan
Existing tests.