[WIP] Add verbose flag - fixes #763 #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sebmck
changed the title
Daniel15
reviewed
Nov 22, 2016
| @@ -22,31 +22,31 @@ async function runGlobal( | |||
| name: string, | |||
| checkGlobal?: ?(config: Config, reporter: Reporter, out: string) => ?Promise<void>, | |||
| ): Promise<void> { | |||
| let out = ''; | |||
| const stdout = new stream.Writable({ | |||
There was a problem hiding this comment.
This is copied and pasted in a few places, what about making a mockOutputStream module to encapsulate it?
There was a problem hiding this comment.
Yeah i noticed this too, I'm going to abstract it out in a subsequent pull request.
|
ping @kittens, a few lint and undefined errors |
added 3 commits
November 24, 2016 14:56
# Conflicts: # __tests__/commands/_helpers.js # __tests__/commands/_init.js # __tests__/commands/global.js # __tests__/commands/list.js # __tests__/commands/outdated.js # __tests__/commands/remove.js # __tests__/commands/run.js # __tests__/commands/upgrade.js
bestander
approved these changes
Nov 24, 2016
|
Looks great! |
bestander
pushed a commit
to bestander/yarn
that referenced
this pull request
Nov 24, 2016
* Add verbose flag - fixes yarnpkg#763 * fix lint * fix lint add verboseInspect method
onemen
reviewed
Nov 25, 2016
| }); | ||
|
|
||
| const reporter = new Reporter({stdout, stderr: stdout}); | ||
|
|
||
| if (beforeInstall) { | ||
| await beforeInstall(cwd); |
There was a problem hiding this comment.
Can you add reporter and out arguments to before install?
if (beforeInstall) {
- await beforeInstall(cwd);
+ await beforeInstall(cwd, reporter, () => out);
}
// remove the lockfile if we create one and it didn't exist before
const lockfile = await createLockfile(cwd);
// create directories
await fs.mkdirp(path.join(cwd, '.yarn-global'));
There was a problem hiding this comment.
@onemen, feel free to send a PR.
Why do we need it?
|
@bestander yarn --verbose isn't mentioned in the documentation : could you add it ? ;) |
|
Please send a PR, we really appreciate when community helps us with
improving the documentation.
…On Sun, Jan 28, 2018 at 1:32 PM Clement Fradet Normand < ***@***.***> wrote:
@bestander <https://github.com/bestander> yarn --verbose isn't mentioned
in the documentation :
https://yarnpkg.com/lang/en/docs/cli/install/
could you add it ? ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1994 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACBdWKTTT5PmvAh7si7p1TaBb4EH0Hyzks5tPOd_gaJpZM4K545g>
.
|
|
ok |
|
I see that there are no open pull requests for adding this option in the docs so I created one in the website repo #782 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, need to add more places to log. Adds verbose logging in the following places: