Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compat): update patch for typescript@5.6.0-beta #6409

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jul 25, 2024

What's the problem this PR addresses?

The PnP compatibility patch for TypeScript doesn't apply to typescript@5.6.0-beta.

Ref microsoft/TypeScript#35206

How did you fix it?

Rebased it.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz force-pushed the merceyz/fix/typescript-56-beta branch from 3ef4151 to a1c8018 Compare July 26, 2024 16:21
@merceyz
Copy link
Member Author

merceyz commented Jul 26, 2024

I usually update our version of TypeScript in these PRs so we can dogfood the patch but with the new version I would need to update @types/node as well which would require adding parentPath to our Dirent implementation, a bit out of scope for this PR.

@merceyz merceyz marked this pull request as ready for review July 26, 2024 16:30
@arcanis arcanis merged commit d087538 into master Jul 29, 2024
24 of 28 checks passed
@arcanis arcanis deleted the merceyz/fix/typescript-56-beta branch July 29, 2024 08:58
merceyz added a commit that referenced this pull request Aug 5, 2024
**What's the problem this PR addresses?**

The PnP compatibility patch for TypeScript doesn't apply to
`typescript@5.6.0-beta`.

Ref microsoft/TypeScript#35206

**How did you fix it?**

Rebased it.

**Checklist**
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).
- [x] I have set the packages that need to be released for my changes to
be effective.
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.

---------

Co-authored-by: Maël Nison <nison.mael@gmail.com>
(cherry picked from commit d087538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants