feat: improve error on missing build

xtreamsrl · Oct 17, 2023 · d4dc268 · d4dc268
1 parent 8cae6dd
commit d4dc268
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/packages/storage-gcp/src/index.ts b/packages/storage-gcp/src/index.ts
@@ -41,8 +41,6 @@ class GCPStorage extends RemoteStorage {
       "utf8"
     );
     const credentials = JSON.parse(jsonFileContent.toString());
-    console.log("credentials", credentials)
-    console.log("options", options);
     const storage = new Storage({
       credentials
     })
@@ -107,7 +105,12 @@ class GCPStorage extends RemoteStorage {
 
   async getBuildInfo(buildId: string): Promise<ProjectBuildInfo> {
     const buildpath = this.getBuildPath(buildId);
-    const fileContent = await this.downloadFileFromGcp(`${buildpath}/info.json`);
+    let fileContent: string = "";
+    try {
+      fileContent = (await this.downloadFileFromGcp(`${buildpath}/info.json`)).toString();
+    }catch (e) {
+      throw new Error(`Build ${buildId} not found`);
+    }
     return JSON.parse(fileContent.toString());
   }
 

diff --git a/packages/storage-s3/src/index.ts b/packages/storage-s3/src/index.ts
@@ -152,7 +152,12 @@ class S3Storage extends RemoteStorage {
 
   async getBuildInfo(buildId: string): Promise<ProjectBuildInfo> {
     const buildpath = this.getBuildPath(buildId);
-    const fileContent = await this.downloadFileFromS3(`${buildpath}/info.json`);
+    let fileContent: string = "";
+    try {
+      fileContent = (await this.downloadFileFromS3(`${buildpath}/info.json`)).toString();
+    }catch (e) {
+      throw new Error(`Build ${buildId} not found`);
+    }
     return JSON.parse(fileContent.toString());
   }