Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup/enhancement of parser #1823

Closed
10 of 11 tasks
jerch opened this issue Dec 10, 2018 · 0 comments · Fixed by #2346
Closed
10 of 11 tasks

cleanup/enhancement of parser #1823

jerch opened this issue Dec 10, 2018 · 0 comments · Fixed by #2346
Assignees
Labels
area/parser area/performance type/debt Technical debt that could slow us down in the long run type/enhancement Features or improvements to existing features
Milestone

Comments

@jerch
Copy link
Member

jerch commented Dec 10, 2018

Things to do (PR #2177):

  • remove Array fallback for the transition table
    This is not needed anymore since all supported engines have typed array support.
  • simplify transition table creation
    With the transition table being a typed array the table can be prefilled with the default transition by a .fill call.
  • dont recreate arrays in r() everytime, instead slice from a blueprint
  • simplify unicode handling in parse
    Use the new NON_ASCII_PRINTABLE where appropriate and restore the error state as error state.

Prolly done with next PRs:

@jerch jerch added area/parser area/performance type/enhancement Features or improvements to existing features labels Dec 10, 2018
@jerch jerch self-assigned this Dec 29, 2018
@jerch jerch added the type/debt Technical debt that could slow us down in the long run label Dec 29, 2018
@jerch jerch changed the title cleanup/refinement of parser cleanup/enhancement of parser Dec 29, 2018
@jerch jerch mentioned this issue Aug 4, 2019
4 tasks
@jerch jerch added this to the 4.0.0 milestone Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/parser area/performance type/debt Technical debt that could slow us down in the long run type/enhancement Features or improvements to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant