Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove JS array buffer version #1811

Closed
jerch opened this issue Dec 4, 2018 · 2 comments
Closed

Deprecate and remove JS array buffer version #1811

jerch opened this issue Dec 4, 2018 · 2 comments
Labels
area/api area/parser area/performance type/plan A meta issue that consists of several sub-issues
Milestone

Comments

@jerch
Copy link
Member

jerch commented Dec 4, 2018

Reminder issue to deprecate and the remove the JS array based buffer implementation. Part of #791.

Currently the JS array based buffer line blocks several cleanups/features to come:

@Tyriar Can we make the typed array version the default in 3.9 yet, and deprecate the JS array thing? And maybe remove the JS array version afterwards? This way we have at least one release with both versions and the typed array as default. I feel abit uneasy about a quick removal of the JS array version, but its kinda needed to get some progress with the list above.

/cc @mofux @bgw

@jerch jerch added area/performance area/api area/parser type/plan A meta issue that consists of several sub-issues labels Dec 4, 2018
@jerch jerch changed the title Deprecate and remove JS string buffer version Deprecate and remove JS array buffer version Dec 4, 2018
@Tyriar
Copy link
Member

Tyriar commented Dec 4, 2018

Can we make the typed array version the default in 3.9 yet, and deprecate the JS array thing?

I'm fine with that. Removal will need to wait until at least 3.10.0 though, we need to be careful as it will be too hard to bring it back once we remove it.

@jerch
Copy link
Member Author

jerch commented Jan 31, 2019

Relocated TODO list into tracking issue, closing issue.

@jerch jerch closed this as completed Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api area/parser area/performance type/plan A meta issue that consists of several sub-issues
Projects
None yet
Development

No branches or pull requests

2 participants