Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use yarn when installed #10

Closed
Haroenv opened this issue Nov 9, 2016 · 1 comment · Fixed by #11
Closed

Use yarn when installed #10

Haroenv opened this issue Nov 9, 2016 · 1 comment · Fixed by #11

Comments

@Haroenv
Copy link
Contributor

Haroenv commented Nov 9, 2016 •
edited
Loading

This should be checked here

relevant issue: facebook/create-react-app#896
@SamVerschueren
Copy link

It was suggested in np as well sindresorhus/np#98. It's a very awesome tool, but at that point we decided that it was a little bit too immature to rely on that. Not sure what the status on Yarn is today, they are working very hard though to push out new features and iron out bugs so yes maybe it could be added for xo-init.

It's also just installing one module here, so the use case is a bit different then in np's case where you want to be 100% sure that what you release really works.

Haroenv added a commit to Haroenv/xo-init that referenced this issue Nov 10, 2016
@Haroenv
Add check if user has yarn.lock in cwd
46a73c0 
There's a bit repetition, should I maybe declare the `execa('npm', ['install', '--save-dev', 'xo'], {cwd: pkgCwd})` or `'npm', ['install', '--save-dev', 'xo']` as a variable and then use `...command`? I wasn't sure what was the best option

closes xojs#10
@Haroenv Haroenv mentioned this issue Nov 10, 2016
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prefer Yarn when available Haroenv/xo-init
2 participants
@SamVerschueren @Haroenv