Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated RandomX, added RandomXL (Loki) #1050

Merged
merged 2 commits into from
Jul 2, 2019
Merged

Integrated RandomX, added RandomXL (Loki) #1050

merged 2 commits into from
Jul 2, 2019

Conversation

SChernykh
Copy link
Contributor

RandomX is now compiled together with xmrig code and can be re-configured on the fly to support multiple RandomX variants.

@xmrig xmrig merged commit 02410fa into xmrig:evo Jul 2, 2019
@Spudz76
Copy link
Contributor

Spudz76 commented Jul 6, 2019

Actually compiles on Win7 with 4.16 compiler, but never shows a hashrate.
Also crashes if difficulty is at maximum (test job from MoneroOcean/meta-miner modified to support rx/wow and it works fine with Linux)

@soupli
Copy link

soupli commented Jul 10, 2019

Ryzen 5 1600 | 4gb ddr4 | "Ubuntu 16.04.6 LTS

Screenshot from 2019-07-10 18:06:59

@necro-nemesis
Copy link

necro-nemesis commented Jul 11, 2019

image
Compiles and works fine in Windows also.

@Spudz76
Copy link
Contributor

Spudz76 commented Jul 12, 2019

I got it to hash on some Windows now, but not all of them. Something with how the rx/wow does memory allocation does not work as reliably as the normal methods for CN algos for some reason. That would be fine if it detected unusable allocations instead of going ahead with mining 0.00H/s

It does also do the 0.00 thing with Linux in fewer cases but it can happen (not sure the trigger, but same memory allocation stuff - probably lack of enough hugepages)

It also will never show a rate when testing hashrate by feeding it a max-diff blank job (not a current/real job). MoneroOcean/meta-miner does this to get its speeds for multi-mining, and rx/wow refuses to hash on block -1, so the workaround is to set the hashrate to 99999 so the meta-miner feeds real jobs into rx/wow, observe for a hashrate, then manually type that rate in for rx/wow.

Hashrate testing with -1 diff fake job is what was mostly causing 0.00 for me. Although that should work...

@Spudz76
Copy link
Contributor

Spudz76 commented Jul 12, 2019

@soupli How do you get the thread breakout in status? I'd love to have that in my logs. I bet its via keystroke which doesn't work for me (systemd service runs my miner apps, no input).

I had previously assumed (having never used it with input enabled) that there was no per-thread reporting at all.

@necro-nemesis
Copy link

I got it to hash on some Windows now, but not all of them. Something with how the rx/wow does memory allocation does not work as reliably as the normal methods for CN algos for some reason. That would be fine if it detected unusable allocations instead of going ahead with mining 0.00H/s

I believe I encountered this anomaly when playing with the number of threads. I have 16 on the system I was testing with and with some thread variations 8<threads<16 in config.json it appeared to have produced this effect. It may be specific to my hardware consisting of 2 CPU's so I didn't previously comment.

@Spudz76
Copy link
Contributor

Spudz76 commented Jul 12, 2019

There are definite issues with multi-cpu, if your motherboard has broken ACPI/NUMA mappings, and disabling NUMA seems to mitigate those for now. Again, this algo has totally new allocation technique (with no options), and has a few bugs compared to the old method. I suppose if the algo allowed NUMA-disable option then it wouldn't have to be globally disabled, just marked as distrustworthy and to use alternate methods as if it weren't there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants