Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #126 should have been in 3.0 #129

Closed
tm1000 opened this issue Oct 16, 2018 · 2 comments
Closed

PR #126 should have been in 3.0 #129

tm1000 opened this issue Oct 16, 2018 · 2 comments

Comments

@tm1000
Copy link

tm1000 commented Oct 16, 2018

This relates to really old versions of nodejs , specifically 0.12.x. Basically the work in #126 destroys anyone using older versions of node-xmpp-server on 0.12.x because of the use of CONST. The issue is the fact that for instance node-xmpp-core has a dep of ltx ^2.2.0 which means that npm will select 2.8.0 which blows up if you are using 0.12.x.

I understand the need to use new ES6 code but priority should be taken to not blow up older versions. This is why it should have been in 3.0.

2018-10-16 13:27 -04:00: lets-chat/node_modules/node-xmpp-server/node_modules/node-xmpp-core/node_modules/ltx/lib/parsers/ltx.js:68
        const lt = data.indexOf('<', pos)
        ^^^^^
SyntaxError: Use of const in strict mode.
@jpcodr
Copy link

jpcodr commented Nov 16, 2018

I have the same issue. I reported an error before (#124) and again the use of es6 it's causes me troubles.
Hope that can be resolve soon. Thanks

@sonnyp
Copy link
Member

sonnyp commented Nov 17, 2018

oops sorry, fixed in v2.8.1

@sonnyp sonnyp closed this as completed Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants