Skip to content

Commit

Permalink
Switch speed 10 from 64x64 to 32x32 partitions
Browse files Browse the repository at this point in the history
Results for speed 10
    PSNR |  PSNR Cb |  PSNR Cr | PSNR HVS |     SSIM |  MS SSIM | CIEDE 2000
-30.9829 | -19.2587 | -15.9204 | -18.5035 | -24.9531 | -17.7345 |   -25.8095

11% increase in execution time
  • Loading branch information
KyleSiefring committed Jan 21, 2020
1 parent 6f95b4a commit 8d3affb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/api/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ impl SpeedSettings {
} else if speed <= 9 {
PartitionRange::new(BlockSize::BLOCK_32X32, BlockSize::BLOCK_64X64)
} else {
PartitionRange::new(BlockSize::BLOCK_64X64, BlockSize::BLOCK_64X64)
PartitionRange::new(BlockSize::BLOCK_32X32, BlockSize::BLOCK_32X32)
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/encoder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2208,7 +2208,7 @@ fn encode_partition_bottomup<T: Pixel, W: Writer>(
let bsh = bsize.height_mi();
let is_square = bsize.is_sqr();

// FIXME: ask codeview what to write before assert before committing
// TODO: Update for 128x128 superblocks
assert!(fi.partition_range.max <= BlockSize::BLOCK_64X64);
// Always split if the current partition is too large, i.e. right or bottom tile border
let must_split = (tile_bo.0.x + bsw as usize > ts.mi_width
Expand Down Expand Up @@ -2494,7 +2494,7 @@ fn encode_partition_topdown<T: Pixel, W: Writer>(
let is_square = bsize.is_sqr();
let rdo_type = RDOType::PixelDistRealRate;

// FIXME: ask codeview what to write before assert before committing
// TODO: Update for 128x128 superblocks
assert!(fi.partition_range.max <= BlockSize::BLOCK_64X64);
// Always split if the current partition is too large, i.e. right or bottom tile border
let must_split = (tile_bo.0.x + bsw as usize > ts.mi_width
Expand Down

0 comments on commit 8d3affb

Please sign in to comment.