Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance xcube affine_transform_dataset() #679

Merged
merged 2 commits into from
May 5, 2022
Merged

Enhance xcube affine_transform_dataset() #679

merged 2 commits into from
May 5, 2022

Conversation

forman
Copy link
Member

@forman forman commented May 5, 2022

xcube.core.resampling.affine_transform_dataset() has a new keyword argument reuse_coords: bool = False. If set to True the returned dataset will reuse the same spatial coordinates as the target. This is a workaround for xarray issue pydata/xarray#6573.

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in CHANGES.md
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

@forman forman self-assigned this May 5, 2022
@forman forman marked this pull request as ready for review May 5, 2022 07:23
@forman
Copy link
Member Author

forman commented May 5, 2022

FYI @TonioF (get well soon!)

martin-boettcher
martin-boettcher approved these changes May 5, 2022
View reviewed changes
test/core/gridmapping/test_coords.py Show resolved Hide resolved
xcube/core/gridmapping/coords.py Show resolved Hide resolved
@forman forman merged commit 37f8032 into master May 5, 2022
@forman forman deleted the forman-xxx-enhance_gm_to_coords branch May 17, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-boettcher martin-boettcher martin-boettcher approved these changes

Assignees

@forman forman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forman @martin-boettcher