Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support xcube viewer's pixel info box #1052

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Support xcube viewer's pixel info box #1052

merged 4 commits into from
Jul 29, 2024

Conversation

forman
Copy link
Member

@forman forman commented Jul 29, 2024

This PR supports xcube-dev/xcube-viewer#404.

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/source/*
  • Changes documented in CHANGES.md
  • GitHub CI passes
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

@forman forman requested a review from konstntokas July 29, 2024 13:08
@forman forman marked this pull request as ready for review July 29, 2024 13:08
Copy link
Contributor

@konstntokas konstntokas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. :)
See my little suggestion below.

xcube/server/api.py Outdated Show resolved Hide resolved
Co-authored-by: Konstantin Ntokas <38956538+konstntokas@users.noreply.github.com>
@forman forman merged commit 3933594 into main Jul 29, 2024
1 of 2 checks passed
@forman forman deleted the forman-map_tooltip branch July 29, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants