Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adding ml-datasets from S3 to viewer in JL #1008

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Fix adding ml-datasets from S3 to viewer in JL #1008

merged 2 commits into from
Jun 7, 2024

Conversation

forman
Copy link
Member

@forman forman commented Jun 7, 2024 •
edited
Loading

Quick fix for #1007

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/source/*
  • Changes documented in CHANGES.md
  • GitHub CI passes
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

@forman forman marked this pull request as ready for review June 7, 2024 11:14
@forman forman requested a review from konstntokas June 7, 2024 11:14
konstntokas
konstntokas approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@konstntokas konstntokas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine. Only quick look though..

@forman forman merged commit 46c9758 into main Jun 7, 2024
3 checks passed
@forman forman deleted the forman-1007-mlds_issue_with_viewer_in_jl branch July 4, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konstntokas konstntokas konstntokas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forman @konstntokas