Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to pass in an SSLContext #119

Closed
bdraco opened this issue Apr 30, 2023 · 2 comments · Fixed by #121
Closed

Ability to pass in an SSLContext #119

bdraco opened this issue Apr 30, 2023 · 2 comments · Fixed by #121

Comments

@bdraco
Copy link

bdraco commented Apr 30, 2023

samsung-tv-ws-api/samsungtvws/async_connection.py

Line 70 in ae5d2b3

ssl_context = ssl.SSLContext()

It would be great if we could pass in an SSLContext so on retry one isn't recreated every time

Screenshot 2023-04-30 at 9 07 53 AM
@bdraco
Copy link
Author

bdraco commented Apr 30, 2023

Another option which is probably a lot easier is to make the ssl context a singleton

@epenet epenet mentioned this issue May 2, 2023
Merged
@epenet
Copy link
Collaborator

epenet commented May 2, 2023

I opened #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make SSLContext a singleton epenet/samsung-tv-ws-api
2 participants
@bdraco @epenet