Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password strength change 1.4.0 #42

Closed
fantawttw opened this issue Oct 12, 2018 · 7 comments
Closed

Password strength change 1.4.0 #42

fantawttw opened this issue Oct 12, 2018 · 7 comments

Comments

@fantawttw
Copy link

Changes have been made to the password algorithm however the user has no way of knowing what you are considering an acceptable password.

Steps to reproduce

  1. Create new sync
  2. set password

Expected behaviour

Able to enter a password of my choosing

Actual behaviour

Forced password policy with no guidelines.
Just a red, amber green bar showing password strength

Client app information

App Platform: Chrome

App Platform Version: 1.4.0

Other info

I don't like systems forcing me to use what they consider a strong password.
eg. "thisisaverystrongpasswordandonlyiknowit" is basically unbreakable but it's not allowed.
however "asdasdasdasdasdasd" is allowed.
Please consider removing the complexity requirement that has been added in.

@nero120
Copy link
Member

nero120 commented Oct 21, 2018

Good idea, will look into improving this.

@hadi-susanto
Copy link

hadi-susanto commented Oct 22, 2018

May i know how current password complexity requirement? My password has symbol, lower case, upper case, numeric, length around 15 characters still rejected. Also if possible just warn user instead of rejection.

@fantawttw
Copy link
Author

Perhaps an option to set whether it is a warning or rejection can be added to the server side code.
That way people running their own server side code can make the choice.

@nero120
Copy link
Member

nero120 commented Oct 30, 2018

@hadirena xBrowserSync utilises angular-complexify which is an angularjs port of jquery.complexify.js. However it looks like jquery.complexify.js is no longer maintained (the website explaining the complexity algorithm is also down) so that's probably a good enough reason to look at replacing this functionality with something else.

zxcvbn seems like it could be a good option.

@nero120
Copy link
Member

nero120 commented Oct 30, 2018

@fantawttw I'd like to keep password validation client-side only.

@fantawttw
Copy link
Author

@fantawttw I'd like to keep password validation client-side only.

I agree with it being client side, The process I was thinking of would be that the server would respond in the initial /info request or some other mechanism (not sure if this is how your code works) stating rejection type
{"maxSyncSize":1048576,"message":"server owner message","status":1,"version":"1.1.4","passwordfail":x}
where passwordfail's x is say 1 reject, or 0 warn.

@nero120
Copy link
Member

nero120 commented Oct 31, 2018

@fantawttw ok I think that's separate enough to warrant it's own issue so we can track the feature request independently. Could I trouble you to raise a new issue for this please?

@nero120 nero120 added this to the v1.4.1 milestone Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants